chore: Log interrupted exception, address comment todo.#131
Merged
kinyoklion merged 2 commits intomainfrom Feb 4, 2026
Merged
Conversation
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/PollingSynchronizerImpl.java
Outdated
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/PollingSynchronizerImpl.java
Show resolved
Hide resolved
tanderson-ld
requested changes
Feb 4, 2026
Contributor
tanderson-ld
left a comment
There was a problem hiding this comment.
Logger inconsistency thread seems legit.
tanderson-ld
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(experimental): Release EAP support for FDv2 data system.
END_COMMIT_OVERRIDE
Note
Low Risk
Behavioral changes are limited to logging and minor exception-handling semantics in polling code; low risk aside from potentially changing how shutdown-related interrupts propagate.
Overview
Improves polling robustness/observability by making
PollingBase.loggerprotectedfor subclasses and clarifying that failures while translating a changeset are treated as invalid data.Updates
PollingSynchronizerImplto handleInterruptedExceptionandExecutionExceptionseparately, emitting debug logs and restoring the thread interrupt flag when interrupted.Written by Cursor Bugbot for commit 5d0ff6e. This will update automatically on new commits. Configure here.